chore: extract memory plugin to liyoungc/hermes-memory-plugin#4
Merged
chore: extract memory plugin to liyoungc/hermes-memory-plugin#4
Conversation
Removes the 25 implementation files merged in #2 (W1-W4-2). The code now lives in a dedicated repo (liyoungc/hermes-memory-plugin) installed via: git clone git@github.com:liyoungc/hermes-memory-plugin.git ~/Projects/hermes-memory-plugin ~/Projects/hermes-memory-plugin/install.sh ~/Projects/hermes-agent The install symlinks plugins/memory/sqlite_vec, plugins/memdebug, and plugins/memreview from the plugin repo into hermes-agent/plugins/. For docker-based deploys, install.sh additionally writes a docker-compose.override.yml with bind mounts so the running container picks up live edits without an image rebuild. Why extract: - git pull upstream/main on this fork is now trivial again (no merge conflicts) - Plugin code can be installed on a vanilla NousResearch fork - Spec edits and prompt iterations land in one place DB at ~/.hermes/memories/memory.db is untouched. Cron jobs in ~/.hermes/cron/jobs.json migrate via install.sh. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the 25 memory-system implementation files merged in #2 (W1-W4-2). The code now lives in a dedicated repo: liyoungc/hermes-memory-plugin.
Why extract
git pull upstream/mainfrom NousResearch becomes trivial again — no merge conflicts inplugins/memory/sqlite_vec/ortests/plugins/memory/.What moved
plugins/memory/sqlite_vec/plugins/memory/sqlite_vec/(in plugin repo)plugins/memdebug/plugins/memdebug/plugins/memreview/plugins/memreview/scripts/import_md.pyscripts/import_md.pyscripts/cron/{weekly_promotion,weekly_apply}.pyscripts/cron/scripts/cutover/cutover.shscripts/cutover/tests/plugins/memory/test_*.pytests/plugins/test_{memdebug,memreview}.pytests/scripts/test_import_md.py25 files, 5,454 LOC removed. No core hermes-agent files modified — these were all additive in #2.
How to install on a fresh checkout
The installer:
hermes-agent/plugins/.docker-compose.override.ymlwith bind mounts (so docker picks up live edits without rebuild).weekly_promotion.py/weekly_apply.pyto~/.hermes/scripts/(scheduler hard-binds that path).What also changed in the plugin repo (beyond verbatim move)
A
_config.pywas added that externalizes hardcoded constants (PHI_BLACKLIST_CHANNELS, FAST_TRACK_DAYS, EXTRACT_MODEL/TEMPERATURE, PROMOTION_*, ENTITY_PREFIX, memory_review_channel_name) to~/.hermes/config.yaml memory.sqlite_vec.*. Defaults match the previous hardcoded values exactly. PHI_BLACKLIST keeps a hard floor oncmio/cbme/medicine(warn if user list omits them).EXTRACT_PROMPTandPROMOTION_PROMPTstay hardcoded — they ARE the contract.Deploy state on chococlaw
✅ Already migrated (this PR documents the corresponding fork-side change):
~/Projects/hermes-memory-plugin/clonedinstall.shran successfully — symlinks + override.yml in place/memdebug 我太太生日→ top-1**生日**: 3/19(sim=0.604), unchanged from pre-extraction baseline~/.hermes/memories/memory.db.before-extract-*Test plan
install.shsmoke-tested locally/memdebugretrieval result identical to pre-extractionRollback
If anything breaks:
The DB is never touched. Worst case ~10 min downtime.
🤖 Generated with Claude Code