-
Notifications
You must be signed in to change notification settings - Fork 164
Add File Manager #1330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Add File Manager #1330
Changes from all commits
0c784fa
f4ee0ec
d7adc4b
454d0f3
76a9084
41b3372
a750bad
095e017
ba9b5bf
adc7153
2311744
4ee88af
cae6c41
eea0df5
13834d1
5d24640
5b6b0bb
cc03f39
df80a79
53736a2
ea7af55
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,3 +12,4 @@ yarn-error.log | |
| *.env | ||
| /composer.phar | ||
| *.cache | ||
| /.vs | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| <?php | ||
|
|
||
| namespace App\Http\Controllers; | ||
|
|
||
| use Illuminate\Support\Facades\Auth; | ||
|
|
||
| class FileManagerController extends Controller { | ||
| public function index() { | ||
| if (!Auth::check() || !Auth::user()->isStaff || !Auth::user()->hasPower('manage_files')) { | ||
| abort(404); | ||
| } | ||
|
|
||
| return view('filemanager'); | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,6 +9,7 @@ | |
| "license": "MIT", | ||
| "require": { | ||
| "php": "^8.1", | ||
| "alexusmai/laravel-file-manager": "^3.1", | ||
| "doctrine/dbal": "^3.7", | ||
| "erusev/parsedown": "^1.7", | ||
| "ezyang/htmlpurifier": "^4.10", | ||
|
|
@@ -28,7 +29,8 @@ | |
| "socialiteproviders/tumblr": "^4.1", | ||
| "socialiteproviders/twitch": "^5.3", | ||
| "spatie/laravel-feed": "^4.1", | ||
| "spatie/laravel-honeypot": "^4.1" | ||
| "spatie/laravel-honeypot": "^4.1", | ||
| "tinymce/tinymce": "5.4.2" | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It might be better to handle this via npm and include it in what mix handles... Probably out of scope for this PR, though.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. All told, it might be easier to update tinyMCE that way in a separate PR, and then apply these changes on top... as it is, this is a tough PR to review because the signal/noise ratio is a bit dire due to the update changes.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would it be worth it to even update tinymce to a higher version like v7 for the enhanced code editor to merge that into core? Adding the reference here
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've had issues with tinyMCE versions past... 6.7.3, it looks like? where the toolbar likes to vanish. though it may be a quirk of vite or something. But, assuming that doesn't kick in, potentially?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @itinerare Did it load without the toolbar and take way too long to have the toolbar appear? I had that issue and seemed to resolve it by removing addons/plugins I didn't necessarily use (spoiler, emojis, etc) and now it loads much faster. Potentially a similar cause?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The toolbar just never loaded-- but this is, again, only on versions after the stated one, so not something that should impact LK unless you've gone out of your way to update it. |
||
| }, | ||
| "require-dev": { | ||
| "fakerphp/faker": "^1.9.1", | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.