feat: multiple trait subtypes #1365
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…extension/multiple-trait-subtypes-v3.1
…s' into extension/multiple-trait-subtypes-v3.1
…s' into extension/multiple-trait-subtypes-v3.1
…izations/lorekeeper into extension/multiple-trait-subtypes
…s' into extension/multiple-trait-subtypes-v3.1
…s' into extension/multiple-trait-subtypes-v3.1
…s' into extension/multiple-trait-subtypes-v3.1
…raconizations/lorekeeper into extension/multiple-trait-subtypes-v3.1
itinerare
added
enhancement
Draconizations
force-pushed
the
feat/multiple-trait-subtypes
branch
from
5449290 to
e05b2aa
Compare
Draconizations
force-pushed
the
feat/multiple-trait-subtypes
branch
from
68f0d92 to
110f425
Compare
SpeedyD
reviewed
Nov 26, 2025
ScuffedNewt
reviewed
Nov 26, 2025
SpeedyD
reviewed
Nov 27, 2025
SpeedyD
reviewed
Nov 27, 2025
Draconizations
force-pushed
the
feat/multiple-trait-subtypes
branch
2 times, most recently
from
6fda0f4 to
09f194e
Compare
I swear to god
Draconizations
force-pushed
the
feat/multiple-trait-subtypes
branch
from
423e485 to
2749709
Compare
Author
|
so sorry for the commit mess everyone, turns out having two editors open for different LK repos confused me greatly |
Contributor
|
You may also want to resolve conversations you've fixed :) |
SpeedyD
reviewed
Nov 27, 2025
Contributor
SpeedyD
left a comment
SpeedyD
left a comment
There was a problem hiding this comment.
Aight, so, real review time: My brain is exhausted, but I think it looks good? I however cannot in good conscience approve it until I look it over and test properly when NOT exhausted..
Sorry for that. ^^;;
…nto feat/multiple-trait-subtypes
SpeedyD
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally opening a PR for this ext of mine. Similar to multiple character subtypes, but for traits instead. It should replace every reference to a
subtype_idin the Feature model to use thesubtypesrelation instead, but there's always a chance I missed some. The enhanced trait dropdown and trait indexes are supported as well.Run
php artisan convert-trait-subtypeafter migrations. This does drop thesubtype_idcolumn, so any extensions that reference it will become incompatible.