feat(tests): set up automatic testing via github actions

.github/workflows/laravel.yml

@@ -0,0 +1,42 @@
+name: Laravel-Tests
+
+on:
+  push:
+    branches:
+      - '**'
+  pull_request:
+    branches:
+      - '**'
+
+jobs:
+  laravel-tests:
+
+    runs-on: ubuntu-latest
+
+    services:
+      mysql:
+          image: mysql:5.7
+          env:
+              MYSQL_ALLOW_EMPTY_PASSWORD: yes
+              MYSQL_DATABASE: lorekeeper_test
+          ports:
+              - 3306
+          options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3
+
+    steps:
+    - uses: shivammathur/setup-php@15c43e89cdef867065b0213be354c2841860869e
+      with:
+        php-version: '7.4'
+    - uses: actions/checkout@v2
+    - name: Copy .env
+      run: php -r "file_exists('.env') || copy('.env.example', '.env');"
+    - name: Install Dependencies
+      run: composer install -q --no-ansi --no-interaction --no-scripts --no-progress --prefer-dist
+    - name: Generate key
+      run: php artisan key:generate
+    - name: Directory Permissions
+      run: chmod -R 777 storage bootstrap/cache
+    - name: Execute tests (Unit and Feature tests) via PHPUnit
+      run: php artisan test
+      env:
+        DB_PORT: ${{ job.services.mysql.ports[3306] }}

.gitignore

@@ -11,4 +11,5 @@ npm-debug.log
 yarn-error.log
 *.env
 /composer.phar
+*.env.testing
 *.cache

app/Http/Controllers/Admin/Characters/CharacterController.php

@@ -113,7 +113,7 @@ public function postCreateCharacter(Request $request, CharacterManager $service)
             return redirect()->to($character->url);
         } else {
             foreach ($service->errors()->getMessages()['error'] as $error) {
-                flash($error)->error();
+                $service->addError($error);
             }
         }
 
@@ -145,7 +145,7 @@ public function postCreateMyo(Request $request, CharacterManager $service) {
             return redirect()->to($character->url);
         } else {
             foreach ($service->errors()->getMessages()['error'] as $error) {
-                flash($error)->error();
+                $service->addError($error);
             }
         }
 
@@ -219,7 +219,7 @@ public function postEditCharacterStats(Request $request, CharacterManager $servi
             return redirect()->to($this->character->url);
         } else {
             foreach ($service->errors()->getMessages()['error'] as $error) {
-                flash($error)->error();
+                $service->addError($error);
             }
         }
 
@@ -251,7 +251,7 @@ public function postEditMyoStats(Request $request, CharacterManager $service, $i
             return redirect()->to($this->character->url);
         } else {
             foreach ($service->errors()->getMessages()['error'] as $error) {
-                flash($error)->error();
+                $service->addError($error);
             }
         }
 
@@ -318,7 +318,7 @@ public function postEditCharacterDescription(Request $request, CharacterManager
             return redirect()->to($this->character->url);
         } else {
             foreach ($service->errors()->getMessages()['error'] as $error) {
-                flash($error)->error();
+                $service->addError($error);
             }
         }
 
@@ -347,7 +347,7 @@ public function postEditMyoDescription(Request $request, CharacterManager $servi
             return redirect()->to($this->character->url);
         } else {
             foreach ($service->errors()->getMessages()['error'] as $error) {
-                flash($error)->error();
+                $service->addError($error);
             }
         }
 
@@ -376,7 +376,7 @@ public function postCharacterSettings(Request $request, CharacterManager $servic
             return redirect()->to($this->character->url);
         } else {
             foreach ($service->errors()->getMessages()['error'] as $error) {
-                flash($error)->error();
+                $service->addError($error);
             }
         }
 
@@ -405,7 +405,7 @@ public function postMyoSettings(Request $request, CharacterManager $service, $id
             return redirect()->to($this->character->url);
         } else {
             foreach ($service->errors()->getMessages()['error'] as $error) {
-                flash($error)->error();
+                $service->addError($error);
             }
         }
 
@@ -470,7 +470,7 @@ public function postCharacterDelete(Request $request, CharacterManager $service,
             return redirect()->to('masterlist');
         } else {
             foreach ($service->errors()->getMessages()['error'] as $error) {
-                flash($error)->error();
+                $service->addError($error);
             }
         }
 
@@ -497,7 +497,7 @@ public function postMyoDelete(Request $request, CharacterManager $service, $id)
             return redirect()->to('myos');
         } else {
             foreach ($service->errors()->getMessages()['error'] as $error) {
-                flash($error)->error();
+                $service->addError($error);
             }
         }
 
@@ -522,7 +522,7 @@ public function postTransfer(Request $request, CharacterManager $service, $slug)
             flash('Character transferred successfully.')->success();
         } else {
             foreach ($service->errors()->getMessages()['error'] as $error) {
-                flash($error)->error();
+                $service->addError($error);
             }
         }
 
@@ -547,7 +547,7 @@ public function postMyoTransfer(Request $request, CharacterManager $service, $id
             flash('Character transferred successfully.')->success();
         } else {
             foreach ($service->errors()->getMessages()['error'] as $error) {
-                flash($error)->error();
+                $service->addError($error);
             }
         }
 
@@ -630,7 +630,7 @@ public function postTransferQueue(Request $request, CharacterManager $service, $
             }
         } else {
             foreach ($service->errors()->getMessages()['error'] as $error) {
-                flash($error)->error();
+                $service->addError($error);
             }
         }
 
@@ -728,7 +728,7 @@ public function postTradeQueue(Request $request, TradeManager $service, $id) {
             flash('Trade rejected.')->success();
         } else {
             foreach ($service->errors()->getMessages()['error'] as $error) {
-                flash($error)->error();
+                $service->addError($error);
             }
         }
 

app/Http/Controllers/Admin/Characters/CharacterImageController.php

@@ -82,7 +82,7 @@ public function postNewImage(Request $request, CharacterManager $service, $slug)
             flash('Image uploaded successfully.')->success();
         } else {
             foreach ($service->errors()->getMessages()['error'] as $error) {
-                flash($error)->error();
+                $service->addError($error);
             }
 
             return redirect()->back()->withInput();
@@ -128,7 +128,7 @@ public function postEditImageFeatures(Request $request, CharacterManager $servic
             flash('Character traits edited successfully.')->success();
         } else {
             foreach ($service->errors()->getMessages()['error'] as $error) {
-                flash($error)->error();
+                $service->addError($error);
             }
         }
 
@@ -181,7 +181,7 @@ public function postEditImageNotes(Request $request, CharacterManager $service,
             flash('Image notes edited successfully.')->success();
         } else {
             foreach ($service->errors()->getMessages()['error'] as $error) {
-                flash($error)->error();
+                $service->addError($error);
             }
         }
 
@@ -220,7 +220,7 @@ public function postEditImageCredits(Request $request, CharacterManager $service
             flash('Image credits edited successfully.')->success();
         } else {
             foreach ($service->errors()->getMessages()['error'] as $error) {
-                flash($error)->error();
+                $service->addError($error);
             }
         }
 
@@ -258,7 +258,7 @@ public function postImageReupload(Request $request, CharacterManager $service, $
             flash('Image uploaded successfully.')->success();
         } else {
             foreach ($service->errors()->getMessages()['error'] as $error) {
-                flash($error)->error();
+                $service->addError($error);
             }
         }
 
@@ -283,7 +283,7 @@ public function postImageSettings(Request $request, CharacterManager $service, $
             flash('Image settings edited successfully.')->success();
         } else {
             foreach ($service->errors()->getMessages()['error'] as $error) {
-                flash($error)->error();
+                $service->addError($error);
             }
         }
 
@@ -320,7 +320,7 @@ public function postImageActive(Request $request, CharacterManager $service, $id
             flash('Active character image set successfully.')->success();
         } else {
             foreach ($service->errors()->getMessages()['error'] as $error) {
-                flash($error)->error();
+                $service->addError($error);
             }
         }
 
@@ -357,7 +357,7 @@ public function postImageDelete(Request $request, CharacterManager $service, $id
             flash('Character image deleted successfully.')->success();
         } else {
             foreach ($service->errors()->getMessages()['error'] as $error) {
-                flash($error)->error();
+                $service->addError($error);
             }
         }
 
@@ -384,7 +384,7 @@ public function postSortImages(Request $request, CharacterManager $service, $slu
             return redirect()->back();
         } else {
             foreach ($service->errors()->getMessages()['error'] as $error) {
-                flash($error)->error();
+                $service->addError($error);
             }
         }
 

app/Http/Controllers/Admin/Characters/GrantController.php

@@ -25,7 +25,7 @@ public function postCharacterCurrency($slug, Request $request, CurrencyManager $
             flash('Currency granted successfully.')->success();
         } else {
             foreach ($service->errors()->getMessages()['error'] as $error) {
-                flash($error)->error();
+                $service->addError($error);
             }
         }
 
@@ -46,7 +46,7 @@ public function postCharacterItems($slug, Request $request, InventoryManager $se
             flash('Items granted successfully.')->success();
         } else {
             foreach ($service->errors()->getMessages()['error'] as $error) {
-                flash($error)->error();
+                $service->addError($error);
             }
         }
 

app/Http/Controllers/Admin/Data/CharacterCategoryController.php

@@ -82,7 +82,7 @@ public function postCreateEditCharacterCategory(Request $request, CharacterCateg
             return redirect()->to('admin/data/character-categories/edit/'.$category->id);
         } else {
             foreach ($service->errors()->getMessages()['error'] as $error) {
-                flash($error)->error();
+                $service->addError($error);
             }
         }
 
@@ -117,7 +117,7 @@ public function postDeleteCharacterCategory(Request $request, CharacterCategoryS
             flash('Category deleted successfully.')->success();
         } else {
             foreach ($service->errors()->getMessages()['error'] as $error) {
-                flash($error)->error();
+                $service->addError($error);
             }
         }
 
@@ -136,7 +136,7 @@ public function postSortCharacterCategory(Request $request, CharacterCategorySer
             flash('Category order updated successfully.')->success();
         } else {
             foreach ($service->errors()->getMessages()['error'] as $error) {
-                flash($error)->error();
+                $service->addError($error);
             }
         }
 

app/Http/Controllers/Admin/Data/CurrencyController.php

@@ -82,7 +82,7 @@ public function postCreateEditCurrency(Request $request, CurrencyService $servic
             return redirect()->to('admin/data/currencies/edit/'.$currency->id);
         } else {
             foreach ($service->errors()->getMessages()['error'] as $error) {
-                flash($error)->error();
+                $service->addError($error);
             }
         }
 
@@ -117,7 +117,7 @@ public function postDeleteCurrency(Request $request, CurrencyService $service, $
             flash('Currency deleted successfully.')->success();
         } else {
             foreach ($service->errors()->getMessages()['error'] as $error) {
-                flash($error)->error();
+                $service->addError($error);
             }
         }
 
@@ -149,7 +149,7 @@ public function postSortCurrency(Request $request, CurrencyService $service, $ty
             flash('Currency order updated successfully.')->success();
         } else {
             foreach ($service->errors()->getMessages()['error'] as $error) {
-                flash($error)->error();
+                $service->addError($error);
             }
         }
 

app/Http/Controllers/Admin/Data/FeatureController.php

@@ -90,7 +90,7 @@ public function postCreateEditFeatureCategory(Request $request, FeatureService $
             return redirect()->to('admin/data/trait-categories/edit/'.$category->id);
         } else {
             foreach ($service->errors()->getMessages()['error'] as $error) {
-                flash($error)->error();
+                $service->addError($error);
             }
         }
 
@@ -125,7 +125,7 @@ public function postDeleteFeatureCategory(Request $request, FeatureService $serv
             flash('Category deleted successfully.')->success();
         } else {
             foreach ($service->errors()->getMessages()['error'] as $error) {
-                flash($error)->error();
+                $service->addError($error);
             }
         }
 
@@ -144,7 +144,7 @@ public function postSortFeatureCategory(Request $request, FeatureService $servic
             flash('Category order updated successfully.')->success();
         } else {
             foreach ($service->errors()->getMessages()['error'] as $error) {
-                flash($error)->error();
+                $service->addError($error);
             }
         }
 
@@ -248,7 +248,7 @@ public function postCreateEditFeature(Request $request, FeatureService $service,
             return redirect()->to('admin/data/traits/edit/'.$feature->id);
         } else {
             foreach ($service->errors()->getMessages()['error'] as $error) {
-                flash($error)->error();
+                $service->addError($error);
             }
         }
 
@@ -283,7 +283,7 @@ public function postDeleteFeature(Request $request, FeatureService $service, $id
             flash('Trait deleted successfully.')->success();
         } else {
             foreach ($service->errors()->getMessages()['error'] as $error) {
-                flash($error)->error();
+                $service->addError($error);
             }
         }
 

app/Http/Controllers/Admin/Data/GalleryController.php

@@ -81,7 +81,7 @@ public function postCreateEditGallery(Request $request, GalleryService $service,
             return redirect()->to('admin/data/galleries/edit/'.$gallery->id);
         } else {
             foreach ($service->errors()->getMessages()['error'] as $error) {
-                flash($error)->error();
+                $service->addError($error);
             }
         }
 
@@ -116,7 +116,7 @@ public function postDeleteGallery(Request $request, GalleryService $service, $id
             flash('Gallery deleted successfully.')->success();
         } else {
             foreach ($service->errors()->getMessages()['error'] as $error) {
-                flash($error)->error();
+                $service->addError($error);
             }
         }