lkl: Remove gettid from host_ops #599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
host_ops.gettid is not called anywhere except in a boot test. The boot test just checks to see if gettid returns a non-zero tid, which makes no sense. I suspect host_ops.gettid was added for some historical reason, but it can now be safely removed. This commit removes it as well as the silly test. Signed-off-by: Ruihan Li <lrh2000@pku.edu.cn>
tavip
approved these changes
May 11, 2025
Member
tavip
left a comment
tavip
left a comment
There was a problem hiding this comment.
LGTM, thanks @lrh2000. For context, gettid was added to help with debugging (some networking issues a while back). I don't think we've used it in a while so I am fine with removing it. @thehajime what do you think?
Member
|
sorry to be late. thanks for the patch ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
host_ops.gettid is not called anywhere except in a boot test. The boot test just checks to see if gettid returns a non-zero tid, which makes no sense.
I suspect host_ops.gettid was added for some historical reason, but it can now be safely removed. This commit removes it as well as the silly test.