Skip to content

android: use v1.3 image for the base image #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thehajime merged 1 commit into from
Feb 19, 2025
Merged

android: use v1.3 image for the base image #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,24 @@ do_steps: &do_steps
- run:
name: android arm32 image build
command: |
## XXX: v1.3 image is the last one which contains the right emulator.
## if we install emulator via sdkmanager, it'll install version 35.3.11.x which isn't able to
## run arm64 image on x86_64 host.
## thus, we stick our old image which has a proper emulator version.
## super dirty, but we may need to overhaul all infrastructure for android build/test.
if [[ $CIRCLE_NODE_INDEX == 1 ]]; then
cd circleci/android/arm32 && docker build --build-arg IMAGE_NAME=lkldocker/circleci-android:$GIT_TAG -t lkldocker/circleci-android-arm32:$GIT_TAG . && cd ../../..
cd circleci/android/arm32 && docker build --build-arg IMAGE_NAME=lkldocker/circleci-android:v1.3 -t lkldocker/circleci-android-arm32:$GIT_TAG . && cd ../../..
fi
- run:
name: android arm64 image build
command: |
## XXX: v1.3 image is the last one which contains the right emulator.
## if we install emulator via sdkmanager, it'll install version 35.3.11.x which isn't able to
## run arm64 image on x86_64 host.
## thus, we stick our old image which has a proper emulator version.
## super dirty, but we may need to overhaul all infrastructure for android build/test.
if [[ $CIRCLE_NODE_INDEX == 1 ]]; then
cd circleci/android/arm64 && docker build --build-arg IMAGE_NAME=lkldocker/circleci-android:$GIT_TAG -t lkldocker/circleci-android-arm64:$GIT_TAG . && cd ../../..
cd circleci/android/arm64 && docker build --build-arg IMAGE_NAME=lkldocker/circleci-android:v1.3 -t lkldocker/circleci-android-arm64:$GIT_TAG . && cd ../../..
fi
- run:
name: qemu x86_64 image build
Expand Down