Bump k8s dependencies #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anik120
requested review from
VaishnaviHire,
cdoern,
derekhiggins,
leseb,
mfleader,
nathan-weinberg,
rhdedgar and
rhuss
as code owners
anik120
force-pushed
the
bump-k8s-deps
branch
from
18289d0 to
6ad7ed4
Compare
Contributor
Author
|
hmm the pre-commit is still failing..let me look closer.. |
anik120
force-pushed
the
bump-k8s-deps
branch
from
38f8ee8 to
e525a0a
Compare
Contributor
Author
|
Found the problem. The installer script needed to be regenerated too. Added a commit with that change 👍🏽 |
anik120
force-pushed
the
bump-k8s-deps
branch
from
7298f6d to
b6c44e4
Compare
Contributor
Author
|
Okay the pre-commit is finally passing 😮💨 Had to switch out a desecrated api usage. (glad this is being done with only 4/5 minor version behind..would have been a bigger lift later) |
Collaborator
|
@mergify rebase |
☑️ Nothing to do, the required conditions are not met
|
Collaborator
|
/lgtm |
|
This pull request has merge conflicts that must be resolved before it can be merged. @anik120 please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork |
Bumps the k8s-dependencies group with 8 updates: | Package | From | To | | --- | --- | --- | | [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) | `0.29.0` | `0.34.2` | | [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) | `0.29.2` | `0.34.2` | | [k8s.io/client-go](https://github.com/kubernetes/client-go) | `0.29.2` | `0.34.2` | | [k8s.io/utils](https://github.com/kubernetes/utils) | `0.0.0-20250502105355-0f33e8f1c979` | `0.0.0-20250604170112-4c0f3b243397` | | [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) | `0.17.2` | `0.22.4` | | [sigs.k8s.io/kustomize/api](https://github.com/kubernetes-sigs/kustomize) | `0.18.0` | `0.21.0` | | [sigs.k8s.io/kustomize/kyaml](https://github.com/kubernetes-sigs/kustomize) | `0.18.1` | `0.21.0` | | [sigs.k8s.io/yaml](https://github.com/kubernetes-sigs/yaml) | `1.4.0` | `1.6.0` | Updates `k8s.io/apiextensions-apiserver` from 0.29.0 to 0.34.2 - [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases) - [Commits](kubernetes/apiextensions-apiserver@v0.29.0...v0.34.2) Updates `k8s.io/apimachinery` from 0.29.2 to 0.34.2 - [Commits](kubernetes/apimachinery@v0.29.2...v0.34.2) Updates `k8s.io/client-go` from 0.29.2 to 0.34.2 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.29.2...v0.34.2) Updates `k8s.io/utils` from 0.0.0-20250502105355-0f33e8f1c979 to 0.0.0-20250604170112-4c0f3b243397 - [Commits](https://github.com/kubernetes/utils/commits) Updates `sigs.k8s.io/controller-runtime` from 0.17.2 to 0.22.4 - [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/controller-runtime@v0.17.2...v0.22.4) Updates `sigs.k8s.io/kustomize/api` from 0.18.0 to 0.21.0 - [Release notes](https://github.com/kubernetes-sigs/kustomize/releases) - [Commits](kubernetes-sigs/kustomize@api/v0.18.0...api/v0.21.0) Updates `sigs.k8s.io/kustomize/kyaml` from 0.18.1 to 0.21.0 - [Release notes](https://github.com/kubernetes-sigs/kustomize/releases) - [Commits](kubernetes-sigs/kustomize@kyaml/v0.18.1...api/v0.21.0) Updates `sigs.k8s.io/yaml` from 1.4.0 to 1.6.0 - [Release notes](https://github.com/kubernetes-sigs/yaml/releases) - [Changelog](https://github.com/kubernetes-sigs/yaml/blob/master/RELEASE.md) - [Commits](kubernetes-sigs/yaml@v1.4.0...v1.6.0) --- updated-dependencies: - dependency-name: k8s.io/apiextensions-apiserver dependency-version: 0.34.2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-dependencies - dependency-name: k8s.io/apimachinery dependency-version: 0.34.2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-dependencies - dependency-name: k8s.io/client-go dependency-version: 0.34.2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-dependencies - dependency-name: k8s.io/utils dependency-version: 0.0.0-20250604170112-4c0f3b243397 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-dependencies - dependency-name: sigs.k8s.io/controller-runtime dependency-version: 0.22.4 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-dependencies - dependency-name: sigs.k8s.io/kustomize/api dependency-version: 0.21.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-dependencies - dependency-name: sigs.k8s.io/kustomize/kyaml dependency-version: 0.21.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-dependencies - dependency-name: sigs.k8s.io/yaml dependency-version: 1.6.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: k8s-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Anik Bhattacharjee <anbhatta@redhat.com>
Signed-off-by: Anik Bhattacharjee <anbhatta@redhat.com>
Had to rewrite logServiceEndpoints function:
- Changed from using corev1.Endpoints to discoveryv1.EndpointSliceList
- Now lists all EndpointSlices for a service using the kubernetes.io/service-name label
- Updated logic to work with the new EndpointSlice structure where:
- Each endpoint has a Conditions.Ready field instead of separate ready/not-ready address lists
- Ports are at the slice level with optional pointer fields
Signed-off-by: Anik Bhattacharjee <anbhatta@redhat.com>
anik120
force-pushed
the
bump-k8s-deps
branch
from
bf6a1a6 to
6b6c579
Compare
Contributor
Author
|
@VaishnaviHire done! |
Contributor
Author
|
cc: @nathan-weinberg fyi |
Collaborator
|
@anik120 You might need to run Also the vendor directory should be removed |
VaishnaviHire
requested changes
Nov 19, 2025
Collaborator
VaishnaviHire
left a comment
VaishnaviHire
left a comment
There was a problem hiding this comment.
Need to remove vendor directory
Contributor
Author
|
Ah I see what happened. I'd opened up #199 thinking pre-commit hook is incorrect, but looks like somehow my vendor changes got committed. Let me remove it first and then check the .gitignore... |
Signed-off-by: Anik Bhattacharjee <anbhatta@redhat.com>
anik120
force-pushed
the
bump-k8s-deps
branch
from
aa3f7ea to
26dd01a
Compare
Contributor
Author
|
Okay pre-commit passed for this one. Turns out, we need #200 |
VaishnaviHire
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#184 is failing the pre-commit check because the manifests needed to be re-generated after the k8s bumps. This PR adds:
Signed-off-by: Anik Bhattacharjee anbhatta@redhat.com