KeyValueSorter and CompressArray Improvements#350
Merged
Conversation
…ruction by taking ownership of keys and values arrrays
Collaborator
|
Could you add tests for the new algorithms to the test/ folder? Besides that looks good |
adayton1
approved these changes
Dec 23, 2025
Member
|
I want to merge this in before I release. |
dtaller
approved these changes
Dec 23, 2025
liu15
reviewed
Dec 23, 2025
| int numKept = 0; | ||
|
|
||
| // First, identify which elements to keep | ||
| SCAN_LOOP(i, 0, arrLen, pos, numKept, list[i] == 0) { |
Collaborator
There was a problem hiding this comment.
Could the remove_flag_list and keep_flag_list cases be combined to one case that calculates keepIndices in two different ways?
Member
There was a problem hiding this comment.
It could probably be simplified. I'm just upstreaming Peter's changes to our fork of CARE, so I'm hesitant to make additional changes.
liu15
approved these changes
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#Summary
CompressArray has learned two new modes, remove_flag and keep_flag, and now returns length of the resulting array.
KeyValueSorter can now sort by Key and then Valuie within matching keys.
Sum methods' return type is now a separate template parameter, allowing return of different types.