Add support for building Aluminum as a submodule#173
Open
benson31 wants to merge 4 commits intollnl:hydrogenfrom
Open
Add support for building Aluminum as a submodule#173benson31 wants to merge 4 commits intollnl:hydrogenfrom
benson31 wants to merge 4 commits intollnl:hydrogenfrom
Conversation
ndryden
approved these changes
Nov 15, 2023
tbennun
approved these changes
Nov 22, 2023
| "not found or not functional.") | ||
| set(EL_HYBRID OFF) | ||
| set(Hydrogen_ENABLE_OPENMP OFF) | ||
| set(HYDROGEN_HAVE_OPENMP OFF) |
There was a problem hiding this comment.
this seems pointless if Hydrogen_ENABLE_OPENMP should set it, but ok
| include("FindAndVerifyExtendedPrecision") | ||
|
|
||
| # LAPACK | ||
| # TODO: This should be cleaned up to better support a consistent view |
There was a problem hiding this comment.
Agreed. This should probably be something like HYDROGEN_BLAS_LIBRARY and set to OPENBLAS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some rougher bits here with having to fish out the variables from the aluminum subdirectory.
Automatic updates to the submodule are supported.