Closed
Conversation
adayton1
approved these changes
Feb 5, 2026
Member
Author
|
@MrBurmark @artv3 Based on discussion in #1985 I have removed the old checks for aligned memory allocators and replaced using the C++17 aligned allocators. Simple testing showed no measurable performance difference between the posix_memalign and std::aligned_alloc. |
rhornung67
approved these changes
Feb 5, 2026
Member
Author
|
Deep sigh, Windows MSVC compiler does not support std::aligned_alloc so the platform specific calls are needed. |
Member
Author
|
Closing PR. Windows MSVC compiler does not support std::aligned_alloc as of 2/5/2026, see notes section. MacOS CI tests were failing when using the std::aligned_alloc allocator. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use C++17 aligned memory allocation rather than platform/compiler allocators
With the adoption of C++17 requirement for RAJA the standard aligned memory allocator (std::aligned_alloc) is available and can replace platform / compiler specific options. This PR removes CMake checks for the platform allocators and simplifies the aligned memory allocator wrappers.
Discussion on removal is in a prior cmake fix that has been closed #1985. This PR replaces that change with a more complete change.