PerfFlowAspect Reader + CPU/Mem Usage#144
Draft
spencer-gre wants to merge 54 commits intollnl:developfrom
Draft
Conversation
- add node object to dataframe
- reorganize data files - restore ts and dur into frame
…a. Renamed and moved pfw test file to the correct folder
- add node object to dataframe
ilumsden
added
area-readers
The PerfFlowAspect Reader used to require that .pfw files (PerfFlowAspect Traces) conform to JSON standard. However, PerfFlowAspect does not generate files that are consistent with JSON. This commit modifies a PerfFlowAspect trace file that does not conform to JSON standard - by adding the closing brace and removing the trailing comma.
Author
|
I've added b07fbf3 to this pull request. This commit ensures that all PerfFlowAspect Trace files can be read without manual modification. |
Member
|
This PR will supersede #101 (we will close #101). @spencer-gre @alizalisan @loudsun1997:
|
Closed
This commit follows remarks that llnl#144 will supersede llnl#101, and specifically prepares for the integration of both an array reader for PerfFlowAspect Array Trace Files (already present) and PerfFlowAspect Object Trace Files (to be added). Additionally removes .json files in the pytest data directory as no longer needed.
Missed two in the prior commit. Refer there for full explanation.
Author
|
b1461b5 and faf48b2 address the following points of the roadmap:
|
This branch cleans up conflicts/redundancies introduced after object reader added. Specifically, JSON files were reintroduced, and references to the original perfflowaspect_reader was being used in the graphframe (and not perfflowaspect_array_reader)
Added test for us to s conversion
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves upon #101 adding ability to read in a PerfFlowAspect log with cpu and memory usage.