expose node ordering to caliper readers#174
Merged
Conversation
7e0143e to
ed2ffb4
Compare
Default to true. Order nodes using caliper's node ordering, which records the order in which functions are called (rather than by alphabetical frame ordering).
ed2ffb4 to
6bbc7e9
Compare
- add error check if want node ordering but file doesn't support it - when creating the graph, don't overwrite the node ordering boolean based on if caliper file has specific metric - update both caliper reader and caliper native reader
a60258d to
af4f8b6
Compare
d91e09e to
d7511db
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #174 +/- ##
===========================================
- Coverage 61.45% 61.21% -0.24%
===========================================
Files 49 49
Lines 5046 5067 +21
Branches 1205 1212 +7
===========================================
+ Hits 3101 3102 +1
- Misses 1707 1723 +16
- Partials 238 242 +4
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default to true. Order nodes using caliper's node ordering, which records the order in which functions are called (rather than by alphabetical frame ordering).
Note to review setting
node_ordering=Falseif the appropriate metric is not in the caliper file (otherwise, have to explicitly turn off node_ordering when calling the reader.