Fix FORTRAN strings handling in MPI_File_[open | set_view]#19
Merged
cchambreau merged 1 commit intollnl:masterfrom Aug 29, 2019
Merged
Fix FORTRAN strings handling in MPI_File_[open | set_view]#19cchambreau merged 1 commit intollnl:masterfrom
cchambreau merged 1 commit intollnl:masterfrom
Conversation
fbef77b to
51b3f77
Compare
Contributor
Author
|
@cchambreau I've rebased this one as well and dropped dependency from #14. Son once #13 is in we can rebase/merge this one. |
51b3f77 to
efec728
Compare
Contributor
Author
|
@cchambreau, rebased on top of #13 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C and FORTRAN handle strings differently (see here and here).
FORTRAN puts the hidden parameters with lengths at the end of the subroutine list. This needs to be considered in the F77 wrapper.
Open MPI handles this in the similar manner.
Way to reproduce:
testfilenativeas C binds two strings fromMPI_File_openandMPI_File_set_viewtogether because\0is missing.NOTES: