Remove native code for Node >= 0.9.1 #17
Conversation
…h does not exist on HttpRequest
|
this is deep. I like simple. I need more time to review it. |
|
Any news on this? |
|
It works - feel free to use it.
|
|
Thanks for the info, it would be nice if someone would update the version on npmjs so that install via npm gets possible… |
|
@lloyd Any intention of merging this? Code looks solid and would remove a lot of build issues. Being most of the overhead is in networking code, cannot imagine the difference between native and JS will make any measurable difference. |
|
@Ognian I went ahead and published the module under the name |
|
@STRML Thank you! |
|
@STRML can you enable issues in your repo since its a new version of toobusy? |
|
@pocesar Just added them. |
|
👍 |
1 similar comment
|
👍 |
6 participants
I'm a big fan of this project and have used it a few times. I noticed a few users having issues running it in restricted environments so I spent some time considering a JS-only version. As it turns out, since the addition of Timers.unref() in 0.9.1, we can safely unref the interval timer which will no longer keep the server open.
In this pull request is a full conversion to a JS-only module as well as a few example fixes. All tests pass and the results are identical, with one small behavior change; the C module would start measuring lag after the first tick (from 500ms onward), while this module starts measuring lag on the first tick.