Skip to content

Conversation

@AmrDeveloper
Copy link
Member

Fix warnings after rebasing with the upstream

  • Deprecation warnings.
  • Missing enum elements to make a switch statement complete.
  • Use Op::create.

Copy link
Collaborator

@xlauko xlauko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks :)

Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM! Can you make a change so we can retrigger the CI after the weekend and check whether those unrelated issues are gone?

@AmrDeveloper
Copy link
Member Author

Awesome, LGTM! Can you make a change so we can retrigger the CI after the weekend and check whether those unrelated issues are gone?

Sure, I will rebase with main branch

@bcardosolopes
Copy link
Member

Errors are unrelated, merging!

@bcardosolopes bcardosolopes merged commit a859f31 into llvm:main Nov 18, 2025
5 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants