Skip to content

[mlir][vector] Skip vector mask elimination for funcs without body #173330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
meshtag wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −0
Open

[mlir][vector] Skip vector mask elimination for funcs without body #173330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions mlir/lib/Dialect/Vector/Transforms/VectorMaskElimination.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,10 @@ void eliminateVectorMasks(IRRewriter &rewriter, FunctionOpInterface function,
if (!vscaleRange)
return;

// Early exit for functions without a body.
if (function.isExternal())
return;

OpBuilder::InsertionGuard g(rewriter);

// Build worklist so we can safely insert new ops in
Expand Down
6 changes: 6 additions & 0 deletions mlir/test/Dialect/Vector/eliminate-masks.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,3 +163,9 @@ func.func @negative_value_bounds_scalable_dim_not_all_true(%tensor: tensor<2x100
"test.some_use"(%mask) : (vector<3x[4]xi1>) -> ()
return
}

// -----

// Test to ensure that functions without a body are skipped.
// CHECK-LABEL: func.func private @decl_only(tensor<*xi32>)
func.func private @decl_only(tensor<*xi32>)