Skip to content

[lit] Drop shell feature from all upstream projects #173341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
boomanaiden154 wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −5
Open

[lit] Drop shell feature from all upstream projects #173341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions compiler-rt/test/lit.common.cfg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,6 @@ def push_dynamic_library_lookup_path(config, new_path):

# Setup test format.
config.test_format = lit.formats.ShTest(execute_external)
if execute_external:
config.available_features.add("shell")

target_is_msvc = bool(re.match(r".*-windows-msvc$", config.target_triple))
target_is_windows = bool(re.match(r".*-windows.*$", config.target_triple))
Expand Down
3 changes: 0 additions & 3 deletions llvm/utils/lit/lit/llvm/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,6 @@ def __init__(self, lit_config, config):
if not self.use_lit_shell and lit_config.update_tests:
print("note: --update-tests is not supported when using external shell")

if not self.use_lit_shell:
features.add("shell")

self.with_system_environment(
[
"ASAN_SYMBOLIZER_PATH",
Expand Down