release/22.x: [lld][COFF] Restore lto-embed-bitcode and -fembed-bitcode Bitcode Embedding Features (#188398)#189375
Merged
c-rhodes merged 1 commit intollvm:release/22.xfrom Mar 31, 2026
Merged
Conversation
Member
Author
|
@HaohaiWen @MaskRay What do you think about merging this PR to the release branch? |
Member
Author
|
@llvm/pr-subscribers-lld @llvm/pr-subscribers-lld-coff Author: llvmbot ChangesBackport 1e99c9e Requested by: @mstorsjo Full diff: https://github.com/llvm/llvm-project/pull/189375.diff 2 Files Affected:
diff --git a/lld/COFF/InputFiles.cpp b/lld/COFF/InputFiles.cpp
index d415955b6093b..0cc3aaeba41e3 100644
--- a/lld/COFF/InputFiles.cpp
+++ b/lld/COFF/InputFiles.cpp
@@ -403,11 +403,6 @@ SectionChunk *ObjFile::readSection(uint32_t sectionNumber,
return nullptr;
}
- // Those sections are generated by -fembed-bitcode and do not need to be kept
- // in executable files.
- if (name == ".llvmbc" || name == ".llvmcmd")
- return nullptr;
-
// Object files may have DWARF debug info or MS CodeView debug info
// (or both).
//
diff --git a/lld/test/COFF/embed-bitcode.test b/lld/test/COFF/embed-bitcode.test
deleted file mode 100644
index 10f88c5c0117d..0000000000000
--- a/lld/test/COFF/embed-bitcode.test
+++ /dev/null
@@ -1,30 +0,0 @@
-# RUN: yaml2obj %s -o %t.obj
-# RUN: lld-link /entry:main /subsystem:console /out:%t.exe %t.obj
-# RUN: llvm-readobj -S %t.exe | FileCheck %s
-
-# CHECK-NOT: Name: .llvmbc
-# CHECK-NOT: Name: .llvmcmd
-
---- !COFF
-header:
- Machine: IMAGE_FILE_MACHINE_AMD64
-
-sections:
- - Name: .text
- Characteristics: [ IMAGE_SCN_CNT_CODE, IMAGE_SCN_MEM_EXECUTE, IMAGE_SCN_MEM_READ ]
- SectionData: "C3"
- - Name: .llvmbc
- Characteristics: [ IMAGE_SCN_MEM_DISCARDABLE ]
- SectionData: "4243C0DE"
- - Name: .llvmcmd
- Characteristics: [ IMAGE_SCN_MEM_DISCARDABLE ]
- SectionData: "2D63633100"
-
-symbols:
- - Name: main
- Value: 0
- SectionNumber: 1
- SimpleType: IMAGE_SYM_TYPE_NULL
- ComplexType: IMAGE_SYM_DTYPE_FUNCTION
- StorageClass: IMAGE_SYM_CLASS_EXTERNAL
-...
|
HaohaiWen
approved these changes
Mar 31, 2026
github-project-automation
bot
moved this from Needs Review
to Needs Merge
in LLVM Release Status
… Embedding Features (llvm#188398) Removes the patches introduced by llvm#150897 which broke LTO embed documented features for creating whole-program-bitcode representations of executables, used in production analysis/rewriting toolsets. This was a documented feature available up until 21.1.8 broken by 22.x release. This previously allowed the users to have a whole-program-bitcode section `.llvmbc` embedded inside of the final executable. (cherry picked from commit 1e99c9e)
github-project-automation
bot
moved this from Needs Merge
to Done
in LLVM Release Status
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 1e99c9e
Requested by: @mstorsjo