[FMV][AArch64] Skip test aarch64-init-cpu-features if runtime unavailable #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able. When we use make to build the llvm-test-suite instead of cmake the test aarch64-init-cpu-features should be skipped unless one of __init_cpu_features_resolver or __init_cpu_features is found. Co-authored-by: Momchil Velikov <momchil.velikov@arm.com>
labrinea
commented
Jul 24, 2025
| SYMBOL = __init_cpu_features | ||
| endif | ||
| SYMBOL := $(shell echo "extern void $(SYMBOL)(void); void (*p)() = $(SYMBOL); int main() {}" | \ | ||
| $(TARGET_LLVMGCC) --rtlib=compiler-rt -x c - -o /dev/null 2>/dev/null && \ |
There was a problem hiding this comment.
I am not sure whether $(TARGET_LLVMGCC) is the right compiler. Also whether --rtlib=compiler-rt should be inferred from the existing CFLAGS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we use make to build the llvm-test-suite instead of cmake
the test aarch64-init-cpu-features should be skipped unless one
of __init_cpu_features_resolver or __init_cpu_features is found.
Co-authored-by: Momchil Velikov momchil.velikov@arm.com