[TOSA] Retag resource literals to signless constants #4367
+103
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Lallapallooza
commented
Nov 5, 2025
Lallapallooza
commented
- Extend ValueTensorLiteral lowering so DenseResourceElementsAttr integers are rebuilt with signless element types before emitting tosa.const, matching the converted tensor type.
- Add lit coverage for resource-backed i32/i64 vtensor literals.
- Add FX importer e2e tests that return constant int32/int64 tensors.
- Extend ValueTensorLiteral lowering so DenseResourceElementsAttr integers are rebuilt with signless element types before emitting tosa.const, matching the converted tensor type. - Add lit coverage for resource-backed i32/i64 vtensor literals. - Add FX importer e2e tests that return constant int32/int64 tensors. Change-Id: I2fecd474c9516b868cd5184f00d4998cf44661d5
Lallapallooza
force-pushed
the
fix-tosa-resource-literal
branch
from
a58c1ce to
640d4c6
Compare
Contributor
Author
catcor01
reviewed
Nov 19, 2025
| attr = DenseResourceElementsAttr::get(newTy, res.getRawHandle()); | ||
| } | ||
| } | ||
| rewriter.replaceOpWithNewOp<tosa::ConstOp>(op, outputTy, attr); |
There was a problem hiding this comment.
Small: these two lines could be removed and the same call would be make from rewriter.replaceOpWithNewOptosa::ConstOp on line 3020.
|
Other than the above small nit this looks good to me. Reviewed. |
sahas3
approved these changes
Nov 19, 2025
| if (auto intTy = dyn_cast<IntegerType>(shapedAttrTy.getElementType())) { | ||
| auto signlessTy = | ||
| IntegerType::get(rewriter.getContext(), intTy.getWidth()); | ||
| if (intTy != signlessTy) { |
Member
There was a problem hiding this comment.
Suggestion: You can check !intTy.isSignless() and then create the signedless type here instead of creating signedless type always and comparing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.