Remove the duplicate UID check as it is not needed.#26
Open
gorrdy wants to merge 11 commits intolnbits:mainfrom
Open
Remove the duplicate UID check as it is not needed.#26gorrdy wants to merge 11 commits intolnbits:mainfrom
gorrdy wants to merge 11 commits intolnbits:mainfrom
Conversation
Co-authored-by: Pavol Rusnak <pavol@rusnak.io>
Co-authored-by: Pavol Rusnak <pavol@rusnak.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The card UID is not so important to be UNIQUE in the database. The reason I created this PR is because this is completely useless and sometimes uses delete their card (and its keys) because of this check. Then they're not able to rewrite the card because they deleted the keys. Ofc they can wipe the card and then pair it again but.. this is not the reality.
Also it (kind of) fixes #3 , orphaned cards that are not able to pair if the wallet is deleted because this cannot happen again. It would be better to fix the #3 as suggested in #3 by cascade delete of the bolt cards but this is not the main purpose of this PR.