BUGFIX: replace AcceleratorException -> AcceleratorError#164
Merged
VitorSouzaLNLS merged 2 commits intomasterfrom Apr 9, 2026
Merged
BUGFIX: replace AcceleratorException -> AcceleratorError#164VitorSouzaLNLS merged 2 commits intomasterfrom
VitorSouzaLNLS merged 2 commits intomasterfrom
Conversation
VitorSouzaLNLS
requested review from
Gabrielrezende-asc,
fernandohds564,
otavio-silveira,
vellosok75 and
xresende
fernandohds564
approved these changes
Mar 30, 2026
Gabrielrezende-asc
approved these changes
Mar 31, 2026
vellosok75
approved these changes
Apr 1, 2026
otavio-silveira
approved these changes
Apr 6, 2026
xresende
approved these changes
Apr 9, 2026
Contributor
|
Same comments as in lnls-fac/trackcpp#88. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inside the optics module, the
calc_beamenvelopefunction was trying to raiseAcceleratorExceptionto set/reset the radiation mode and turn on/off cavities on transport lines; however the accelerator module definesAcceleratorErroras its base exception class.