Add virtual slot information on BPM devices.#347
Draft
gustavosr8 wants to merge 1 commit intomasterfrom
Draft
Conversation
anacso17
requested review from
anacso17,
ericonr,
fernandohds564 and
xresende
fernandohds564
approved these changes
Feb 4, 2026
xresende
approved these changes
Feb 5, 2026
ericonr
reviewed
Feb 10, 2026
Contributor
ericonr
left a comment
ericonr
left a comment
There was a problem hiding this comment.
Looks good!
Commit message:
s/firs/first/
s/could/it can/
What do you mean by SSOT?
Contributor
|
If we deploy this, is the old BPM search class broken? I think it's a bit unfortunate to not have any kind of forward or backwards compatibility here... I see lnls-sirius/dev-packages#1218 (comment) now, and I think the commit here should mention this as well. |
Each AFC BPM is able to handle two BPMs, and this happen in most cases at Sirius. For this reason, when addressing an specific BPM, besides the physical slot, we must also use the virtual slot information - i.e. if it's the first or the second AFC slot. Add this information in the microTCA mapping so it can be used as single source of truth. The siriuspy RaBPMSearch class must be updated to reflect this changes.
gustavosr8
force-pushed
the
bpm-vslot
branch
from
8e75030 to
98178c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each AFC BPM is able to handle two BPMs, and this happen in most cases at Sirius. For this reason, when addressing an specific BPM, besides the physical slot, we must also use the virtual slot information - i.e. if it's the firs or the second AFC slot. Add this information in the microTCA mapping so could be used as SSOT.
Needs to be followed by an update in the RaBPMSearch class from siriuspy.