Improve ROI methods in DVF device and add more reset parameters#1032
Open
Improve ROI methods in DVF device and add more reset parameters#1032
Conversation
xresende
changed the title
henriquesimoes
requested changes
Oct 23, 2023
xresende
requested review from
anacso17,
fernandohds564 and
murilobalves
as code owners
xresende
changed the title
anacso17
approved these changes
Nov 6, 2023
fernandohds564
approved these changes
Nov 6, 2023
murilobalves
approved these changes
Nov 6, 2023
henriquesimoes
requested changes
Nov 21, 2023
Contributor
henriquesimoes
left a comment
henriquesimoes
left a comment
There was a problem hiding this comment.
I've noticed now that some camera parameters are not correct.
| DEVICES.BO_DVF: _get_namedtuple( | ||
| 'DVFParameters', | ||
| _dvfparam_fields, (8, 0.5, 0.5, 0.005, 1024, 1280, 4.8, 5.0)), | ||
| _dvfparam_fields, (1024, 1280, 4, 8, 0.5, 0.5, 0.005, 4.8, 5.0)), |
Contributor
There was a problem hiding this comment.
For the BO_DVF camera, which is an Basler acA1300-75gm (version 106755-13), the width must be multiple of 16 and the height can be any value.
| DEVICES.CAX_DVF1: _get_namedtuple( | ||
| 'DVFParameters', | ||
| _dvfparam_fields, (16, 0.5, 0.5, 0.005, 2064, 3088, 2.4, 5.0)), | ||
| _dvfparam_fields, (2064, 3088, 4, 16, 0.5, 0.5, 0.005, 2.4, 5.0)), |
Contributor
There was a problem hiding this comment.
CAX_DVF1 uses a camera from the same model of BO_DVF (but version 106755-24). This means its resolution is
Contributor
|
@xresende Are you going to implement the changes suggested? What is missing here for merging? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.