Merged
Conversation
Contributor
|
hi @xresende , the siriushla package depends on the waveform variables, so I think we need to keep compatibility, not changing the variable names. I think it is not convenient to break this compatibility. |
Contributor
Author
I created a PR in HLA |
anacso17
reviewed
Sep 22, 2025
fernandohds564
approved these changes
Sep 23, 2025
anacso17
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bugfix addresses issues that we have been having recently with our epics gatways in SIRIUS. We realized when the PV waveform len is larger than the PV defined NELM the gateway crashes.
In this PR pwrsupply.csdev module constants related to WFMs are also renamed and simplified.
IOC tested!