MNT: Update GitHub Workflow#749
Closed
VitorSouzaLNLS wants to merge 4 commits intodev/maint/modernize-installfrom
Closed
MNT: Update GitHub Workflow#749VitorSouzaLNLS wants to merge 4 commits intodev/maint/modernize-installfrom
VitorSouzaLNLS wants to merge 4 commits intodev/maint/modernize-installfrom
Conversation
VitorSouzaLNLS
requested review from
RafaelLyra8,
afonsoln,
anacso17,
fernandohds564 and
xresende
Author
|
I not sure why, but GitHub couldn't find any checks for the tests I did. |
Contributor
|
I didn't understand why you closed this PR, @VitorSouzaLNLS ? In this case, the test is try to install the package, isn't it @anacso17 ? |
Author
The idea was to try to install it in both ubuntus, but reading in more detail I saw that one of the jobs consists of deploying the HLA pages. So it doesn't make much sense (I believe) to run the deployment twice. I was thinking that maybe it would be possible to have 2 different CI workflows, one to install and other to deploy the pages. But I don't know if it's worthy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a suggestion.
As did for Trackcpp #81 and suggested for Dev-packages comment, why don't we change the github workflow to run on both ubuntu 22.04 and 24.04 ?
Also, I saw that in latest "Modernize Install" PRs opened by @fernandohds564, the checkout version updated to
v4.