Merged
Conversation
We were publishing all the movements on nostr but this could be used to deanonymize users, so now we are working only with those status on the specs nostr-protocol/nips#1331
Catrya
reviewed
Sep 3, 2024
Member
There was a problem hiding this comment.
In-progress event is published 2 times
In a buy order it is published when:
- the seller takes the order and goes to
Waiting-payment - the buyer puts the invoice and goes to
Active
In a sales order it is published when:
- the buyer takes the order and goes to
Waiting-buyer-invoice - the buyer puts the invoice and goes to
Waiting-payment
Catrya
reviewed
Sep 3, 2024
Member
Catrya
left a comment
Catrya
left a comment
There was a problem hiding this comment.
success event is published twice when an admin settles the order (when they cancel the order it works fine)
Catrya
reviewed
Sep 3, 2024
Member
Catrya
left a comment
Catrya
left a comment
There was a problem hiding this comment.
cuando un admin hace /checkorder y la orden no está en disputa aparece Status previo a disputa: pero eso solo debería salir cuando está en disputa
Member
Author
creo que esto está fuera del alcance de este review 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were publishing all the movements on nostr but this could be used to deanonymize users, so now we are working only with those status on the specs
nostr-protocol/nips#1331