Test Case For Block Info Handler and Config Functions#18
Open
sandeeplandt wants to merge 5 commits intolntdev:sandeepfrom
Open
Test Case For Block Info Handler and Config Functions#18sandeeplandt wants to merge 5 commits intolntdev:sandeepfrom
sandeeplandt wants to merge 5 commits intolntdev:sandeepfrom
Conversation
askmish
requested changes
Apr 13, 2018
Collaborator
askmish
left a comment
askmish
left a comment
There was a problem hiding this comment.
Please correct spelling and grammar in commit messages and address the review comments.
| expose: | ||
| - 4004 | ||
| command: nose2-3 | ||
| command: nose2-3 --coverage-report term-missing |
Collaborator
There was a problem hiding this comment.
This should probably not be checked in. Do you need to modify this?
| def test_validate_hex_ve(self): | ||
| string_hex = validate_hex("test", 128) | ||
| self.assertEqual(string_hex, False) | ||
|
No newline at end of file |
Collaborator
There was a problem hiding this comment.
Please remove the trailing blank lines at end of file.
| -c /project/sawtooth-core/families/block_info/nose2.cfg | ||
| -v | ||
| -s /project/sawtooth-core/families/block_info/tests | ||
| test_tp_block_info |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test case added for block_info/handler.py and block_info/block_info.py