Added test cases to test_config.py file to load toml config with the …#22
Open
anuja1906 wants to merge 1 commit intolntdev:anujafrom
Open
Added test cases to test_config.py file to load toml config with the …#22anuja1906 wants to merge 1 commit intolntdev:anujafrom
anuja1906 wants to merge 1 commit intolntdev:anujafrom
Conversation
…non existing filename.Also added test cases to merger the three different configuration into one.Added test case to test_rest_api.py file to load the rest api config. Signed-off-by: anuja parate <anujax.parate@intel.com>
| finally: | ||
| os.environ.clear() | ||
| os.environ.update(orig_environ) | ||
| shutil.rmtree(directory) |
Collaborator
There was a problem hiding this comment.
There should be one blank line before every new method definition.
| def test_rest_api_config_load_merge(self): | ||
| '''Tests the "merge_rest_api_config(configs)" function. | ||
| Given a list of PathConfig objects, merges them into | ||
| a single PathConfig,giving priority in the order of |
Collaborator
There was a problem hiding this comment.
add a space after the comma
| 'opentsdb_db = "http://data_base:0000"', | ||
| 'opentsdb_username = "name"', 'opentsdb_password = "secret"'] | ||
| default_dict = OrderedDict([ | ||
| ('bind', "test:1234"), |
Collaborator
There was a problem hiding this comment.
@askmish is this the correct depth of indentation?
| ('opentsdb_username', "name"), | ||
| ('opentsdb_password', "secret")] | ||
| ) | ||
| first_config = RestApiConfig( |
Collaborator
There was a problem hiding this comment.
Please make sure to add blank lines to the code where it makes sense, so that the code becomes more readable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…non existing filename.Also added test cases to merger the
three different configuration into one.Added test case to test_rest_api.py file to load the rest api config.
Signed-off-by: anuja parate anujax.parate@intel.com