Conversation
kulkarniamol
left a comment
kulkarniamol
left a comment
There was a problem hiding this comment.
Add copyright and clean up the comments all through the file.
| @@ -0,0 +1,118 @@ | |||
| import os | |||
There was a problem hiding this comment.
Add copyright statement here.
| class TestSettings(TransactionProcessorTestCase): | ||
|
|
||
| def test_load_toml_settings_config(self): | ||
| """ the test case will create the toml file at a per the environment |
There was a problem hiding this comment.
Basic grammar check: Start a sentence with an uppercase letter. There should be no space BEFORE a comma. There should always be a space AFTER a comma. The second line onwards should always be aligned with the starting " of the comment. End the comment with a '.' (period)
|
|
||
| def test_load_toml_settings_config(self): | ||
| """ the test case will create the toml file at a per the environment | ||
| and the path set,open the file ,write the content in the file and the |
There was a problem hiding this comment.
'...and then instantiate...'
| def test_load_default_settings_config(self): | ||
| """Tests the default configuration. | ||
| connect = "tcp://localhost:4004" """ | ||
| settings = load_default_settings_config() |
There was a problem hiding this comment.
The ending """ needs to be on a new line. The second line needs to be aligned properly.
| a toml file configured with requiremnts is to made available at a | ||
| path. | ||
| this test will test the condition when the toml is not present | ||
| at th path provided""" |
There was a problem hiding this comment.
Spell check, grammar check etc. Pls be advised that this code will be read by the entire Sawtooth community. We want to make sure we present our best foot forward :)
| directory = tempfile.mkdtemp(prefix="test-path-config-") | ||
|
|
||
| try: | ||
| os.environ['SAWTOOTH_HOME'] = directory |
There was a problem hiding this comment.
Do you not need to restore the original environment settings in this test?
Signed-off-by: shourya anand <anand.shourya.01@gmail.com>
|
Looks good. Pls raise PR to HL |
2 participants
created test file for config.py/settings in settings family
Signed-off-by: shourya anand anand.shourya.01@gmail.com