Open
Conversation
shresthichauhan
force-pushed
the
STL-1345_Fix
branch
from
4b613a7 to
460fb4f
Compare
kulkarniamol
requested changes
Jul 26, 2018
Collaborator
kulkarniamol
left a comment
kulkarniamol
left a comment
There was a problem hiding this comment.
The JSON return code should be 62, not 60. 60 is meant to be returned in case of invalid "block, batch or transaction id" as per the documentation.
Also, where is the code where the JSON error is being set?
Currently user will get "Internal Server Error" (no JSON response) with GET/State Bad Head parameter.This fix will resolve the issue and give JSON response with error code 62 for BAD Head parameter. Signed-off-by: shresthichauhan <shresthix.chauhan@intel.com>
shresthichauhan
force-pushed
the
STL-1345_Fix
branch
from
460fb4f to
6ba544a
Compare
Collaborator
Author
|
JSON return code 62 will work for bad head, partial address and wildcard characters -
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix will solve STL-1345 bug.
Currently user will get "Internal Server Error" (no JSON response) with GET/State Bad Head parameter.
This fix will resolve the issue and give JSON response with error code 60 for BAD Head parameter.