Added test cases for Multiple Txns in Batch#51
Open
sandeeplandt wants to merge 22 commits intolntdev:rest_api_testingfrom
Open
Added test cases for Multiple Txns in Batch#51sandeeplandt wants to merge 22 commits intolntdev:rest_api_testingfrom
sandeeplandt wants to merge 22 commits intolntdev:rest_api_testingfrom
Conversation
asing177
requested changes
Aug 29, 2018
rest_api/tests/api_test/fixtures.py
Outdated
| initial_batch_length = batch_count() | ||
| initial_transaction_length = transaction_count() | ||
|
|
||
| LOGGER.info("Creating intkey transactions with set operations") |
Collaborator
There was a problem hiding this comment.
There is a need to generalize these fixtures now....otherwise they will simply add locs
rest_api/tests/api_test/fixtures.py
Outdated
|
|
||
| txns = [ | ||
| create_intkey_same_transaction("set",[],30, signer), | ||
| create_intkey_same_transaction("set",[],30, signer), |
Collaborator
There was a problem hiding this comment.
cant see invalid and valid combo
rest_api/tests/api_test/fixtures.py
Outdated
| txns = [ | ||
| create_intkey_transaction("set",[],30, signer), | ||
| create_intkey_same_transaction("set",[],30, signer), | ||
| create_intkey_same_transaction("set",[],30, signer), |
Collaborator
There was a problem hiding this comment.
where are valid and invalid trnxs?
rest_api/tests/api_test/fixtures.py
Outdated
| data = {} | ||
| signer = get_signer() | ||
| expected_trxn_ids = [] | ||
| expected_batch_ids = [] |
Collaborator
There was a problem hiding this comment.
Please shorten your code
| initial_batch_length = setup_batch_valinv_txns['initial_batch_length'] | ||
| expected_batch_length = setup_batch_valinv_txns['expected_batch_length'] | ||
| initial_trn_length = setup_batch_valinv_txns['initial_trn_length'] | ||
| expected_trn_length = setup_batch_valinv_txns['expected_trn_length'] |
Collaborator
There was a problem hiding this comment.
For post related tests , better create payload in fixtures and call here and then post from the test case
asing177
requested changes
Sep 2, 2018
rest_api/tests/api_test/fixtures.py
Outdated
| header_bytes = header.SerializeToString() | ||
|
|
||
| signature = self.signer.sign(header_bytes) | ||
|
|
Collaborator
There was a problem hiding this comment.
Transaction creation is done in payload file ...then why use Transaction header here....create there and call here....Please rework
Signed-off-by: Ryan Beck-Buysse <rbuysse@bitwise.io>
Signed-off-by: Ryan Beck-Buysse <rbuysse@bitwise.io>
Signed-off-by: Ryan Beck-Buysse <rbuysse@bitwise.io>
In order to reduce the logging noise during debug, add a log guard that will only add the messages about "Not ready to summarize" or "finalize" on the first occurrence. Once the summary or finalization result is returned, the guard is disabled. Signed-off-by: Peter Schwarz <peterx.schwarz@intel.com>
This trait is used to pass the cache of block validation results to the block scheduler. Signed-off-by: Boyd Johnson <bjohnson@bitwise.io>
The python BlockScheduler will be removed once the BlockValidator is re-written in Rust. Signed-off-by: Boyd Johnson <bjohnson@bitwise.io>
Signed-off-by: Boyd Johnson <bjohnson@bitwise.io>
This is a idiomatic change from performing an action inside of a map to an `if let Some`. This also changes the test for contains in a hashmap and then insertion if it does not contain, to hashmap.entry(key).or_insert(value) which is idiomatic rust. Signed-off-by: Boyd Johnson <bjohnson@bitwise.io>
When the field name and the variable are named the same in constructing a struct, the field name should be omitted. Signed-off-by: Boyd Johnson <bjohnson@bitwise.io>
There is less specificity on which parts of the code are unsafe, but marking the function as unsafe is easier to see, and conforms to the clippy rules. Signed-off-by: Boyd Johnson <bjohnson@bitwise.io>
Signed-off-by: Boyd Johnson <bjohnson@bitwise.io>
Signed-off-by: Boyd Johnson <bjohnson@bitwise.io>
Signed-off-by: Boyd Johnson <bjohnson@bitwise.io>
Prior to this commit there was a Clippy lint error about calling mem::forget on a Copy trait, which doesn't have a destructor. Signed-off-by: Boyd Johnson <bjohnson@bitwise.io>
This includes a single pod in devmode, and a 5 pod poet network. Signed-off-by: Richard Berg <rberg@bitwise.io>
Preserve the kubernetes yaml files in the docs build artifacts for publishing. Signed-off-by: Richard Berg <rberg@bitwise.io>
Contains base class for all test classes Contains conftest.py for pytest cli and session fixtures Contains utils.py for utility methods required in calling rest api endpoints and other functions for testing the endpoints Contains Test files inside test folders for rest api testing Includes thread module for various threads for multi validator testing Includes ssh, payload and workload modules for performing ssh, creating payload and generating workload using threads Signed-off-by: aditya singh <adityasingh27@hotmail.com>
Signed-off-by: sandeeplandt <sandeepx.hs@intel.com>
Signed-off-by: sandeeplandt <sandeepx.hs@intel.com>
Signed-off-by: sandeeplandt <sandeepx.hs@intel.com>
Signed-off-by: sandeeplandt <sandeepx.hs@intel.com>
sandeeplandt
force-pushed
the
rest_api_testing
branch
from
359d971 to
20ceb7b
Compare
lntdev
force-pushed
the
rest_api_testing
branch
from
83f6621 to
1930319
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: sandeeplandt sandeepx.hs@intel.com