STL-1346 - JSON Response for Invalid address in state list#56
Open
hariharan-avs wants to merge 1 commit intolntdev:masterfrom
Open
STL-1346 - JSON Response for Invalid address in state list#56hariharan-avs wants to merge 1 commit intolntdev:masterfrom
hariharan-avs wants to merge 1 commit intolntdev:masterfrom
Conversation
asing177
requested review from
anuja1906,
asing177,
mithunshashidhara and
sandeeplandt
asing177
reviewed
Sep 28, 2018
| error = errors.StateNotFound | ||
|
|
||
| class InvalidAddressListTrap(_ErrorTrap): | ||
| trigger = client_state_pb2.ClientStateListResponse.INVALID_ADDRESS |
Collaborator
Author
There was a problem hiding this comment.
Ran lint and resolved errors, changes merged
Mapped the Invalid address error:62 JSON Response to error during query of invalid address to list state. Modified route_handler.py to trap error and map to error 62 via error_handlers.py Removed unused parameter in route_handlers.py - _wrap_response Added docstrings and resolved pylint errors Signed-off-by: Hariharan Subramanian <hariharanx.subramanian@intel.com>
hariharan-avs
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mapped the Invalid address error:62 JSON Response to error
during query of invalid address to list state.
Modified route_handler.py to trap error and map to
error 62 via error_handlers.py
Removed unused argument 'request' in route_handlers.py - _wrap_response to resolve pylint error unused-argument. Added docstrings to modules, classes and methods to resolve pylint error.
Signed-off-by: Hariharan Subramanian hariharanx.subramanian@intel.com