STL-1313 - Post batch with Signer Public Key as string is not responding#57
Open
hariharan-avs wants to merge 1 commit intomasterfrom
Open
STL-1313 - Post batch with Signer Public Key as string is not responding#57hariharan-avs wants to merge 1 commit intomasterfrom
hariharan-avs wants to merge 1 commit intomasterfrom
Conversation
Signing module secp256k1.py updated with returning to value after Parse error exception is raised. This prevents client hanging issue when client supplies bad signer key value. Signed-off-by: Hariharan Subramanian <hariharanx.subramanian@intel.com>
kulkarniamol
requested changes
Oct 10, 2018
Collaborator
kulkarniamol
left a comment
kulkarniamol
left a comment
There was a problem hiding this comment.
I'm not sure this is the right way to fix this issue. Lets talk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signing module secp256k1.py updated with returning to value after
Parse error exception is raised. This prevents client hanging issue
when client supplies bad signer key value.
Signed-off-by: Hariharan Subramanian hariharanx.subramanian@intel.com