Skip to content
This repository was archived by the owner on Jun 18, 2020. It is now read-only.

Refactor#7

Open
jsmartt wants to merge 3 commits intolnxchk:masterfrom
jsmartt:refactor
Open

Refactor#7
jsmartt wants to merge 3 commits intolnxchk:masterfrom
jsmartt:refactor

Conversation

@jsmartt
Copy link

@jsmartt jsmartt commented Sep 22, 2016

Fixes #6

This PR:

  • Pushes the real work back onto the Knife modules
  • Gets the data from the search directly, not through stdout
  • Uses the standard knife UI module to output the data, meaning you can pass in the -F option, and the standard --color and --no-color options
  • Lastly, added an option so that just like the search option, you can pass in -i (or --id-only) to print the IDs only.
  • Updates/adds some README sections

@lnxchk , let me know if you're not willing to service this and release it; if not, I'd probably start from scratch with my own.

@lnxchk
Copy link
Owner

lnxchk commented Sep 23, 2016

I'll take a look at this. I'm kind of surprised it's still being used. I thought most folks had just moved to "knife status".

@jsmartt
Copy link
Author

jsmartt commented Sep 23, 2016

lol. I didn't even notice the hide-by-mins option in knife status. That totally does the same thing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants