Add context arguments to all delayed task methods#129
Merged
Kasekopf merged 7 commits intoloathers:mainfrom Apr 3, 2025
Merged
Add context arguments to all delayed task methods#129Kasekopf merged 7 commits intoloathers:mainfrom
Kasekopf merged 7 commits intoloathers:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a "context" produced by the Engine that can be consumed by all of the methods on a task (ready, completed, delayed combat macros, etc.). Contexts are designed to be computed once per task execution, and can be used for tasks to consider global state when needed.
This could be used to avoid globals like the globalStateCache in loopstar, or to store mine state in oreo.
Typescript is pretty cool about the Void type, so I think this is basically entirely backwards compatible for grimoire scripts.