Merged
Conversation
Member
|
@markconroy - the link text is now invisble on hover ! :) |
Member
Author
|
@msayoung ready for another review. |
msayoung
requested changes
Apr 7, 2025
Member
msayoung
left a comment
There was a problem hiding this comment.
Really sorry @markconroy
This is better , but now when you focus and THEN hover the text returns to white on yellow.
Can we keep it black please?
Member
Author
|
@msayoung I'm not sure this is fixable. I'm not aware of a CSS property for "do this when hovered and focussed at the same time", I think we've only got |
Member
Author
|
@msayoung any thoughts on my last comment above? I think we might need to merge this as is. |
Member
|
@markconroy you can chain psuedo classes so in this case I think we'd want to go for: |
Member
Author
|
@msayoung ready for a retest. |
msayoung
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #307
What does this change?
Sets the focus state for links in footer to be dark (on yellow) instead of white (on yellow)