Conversation
msayoung
left a comment
There was a problem hiding this comment.
This does fix the focus, but it's now black on black on hover.
I think we need to set a specfiic focus colour alongside the focus background colour rather than reusing the hover variable?
|
Whaaaaat? How did I miss that. I'll get it sorted. |
|
Ready again @msayoung |
msayoung
left a comment
There was a problem hiding this comment.
better, but the text is now white on yellow when focus and hover are applied.
|
@msayoung I'm not sure this is fixable. I'm not aware of a CSS property for "do this when hovered and focussed at the same time", I think we've only got :hover and :focus, unless we put !important perhaps on the :hover state? |
|
@markconroy this should do it: |
|
I'm about to test this, and then go a a bottle of champagne if it works. I never even thought of the idea of |
|
@msayoung You're a genius. It works. Let's get this approved |
Closes #306
Sets focus colour for mobile menu items to dark (on yellow) instead of white (on yellow).