Skip to content

Move <div> inside "if content.group_page_bottom"#330

Merged
finnlewis merged 1 commit into2.xfrom
move-div-inside-if-content-page-bottom
Jul 29, 2025
Merged

Move <div> inside "if content.group_page_bottom"#330
finnlewis merged 1 commit into2.xfrom
move-div-inside-if-content-page-bottom

Conversation

@AWearring
Copy link
Contributor

@AWearring AWearring commented Jul 21, 2025

Moving <div class="lgd-container padding-horizontal"> inside {% if content.group_page_bottom %} so that we don't get an empty div when content.group_page_bottom is empty

Without this change we get:

<div class="lgd-container padding-horizontal">
</div>

At the end of the <article>

Moving `<div class="lgd-container padding-horizontal">` inside `{% if content.group_page_bottom %}` so that we don't get an empty `div` when `content.group_page_bottom` is empty
@AWearring AWearring requested a review from markconroy July 21, 2025 22:21
Copy link
Member

@finnlewis finnlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks @AWearring !

@finnlewis finnlewis requested a review from tonypaulbarker July 22, 2025 11:16
@finnlewis
Copy link
Member

I think the logic looks better, removes superfluous html!

@tonypaulbarker is keen to test it further!

@tonypaulbarker
Copy link

This looks good to me. This div is only wrapping group_page_bottom

@finnlewis finnlewis merged commit 58ef4d0 into 2.x Jul 29, 2025
4 of 6 checks passed
@finnlewis
Copy link
Member

@AWearring we've merged this, do you need a release for this?

@AWearring
Copy link
Contributor Author

@finnlewis no hurry for a release for me, thanks for asking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants