Move <div> inside "if content.group_page_bottom"#330
Merged
Conversation
Moving `<div class="lgd-container padding-horizontal">` inside `{% if content.group_page_bottom %}` so that we don't get an empty `div` when `content.group_page_bottom` is empty
finnlewis
approved these changes
Jul 22, 2025
Member
finnlewis
left a comment
There was a problem hiding this comment.
looks good to me, thanks @AWearring !
Member
|
I think the logic looks better, removes superfluous html! @tonypaulbarker is keen to test it further! |
|
This looks good to me. This div is only wrapping group_page_bottom |
tonypaulbarker
approved these changes
Jul 22, 2025
Member
|
@AWearring we've merged this, do you need a release for this? |
Contributor
Author
|
@finnlewis no hurry for a release for me, thanks for asking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving
<div class="lgd-container padding-horizontal">inside{% if content.group_page_bottom %}so that we don't get an emptydivwhencontent.group_page_bottomis emptyWithout this change we get:
At the end of the
<article>