Check to see if off canvas region is expanded before firing close han…#342
Merged
Check to see if off canvas region is expanded before firing close han…#342
Conversation
Member
|
Just remembered we have this fixed and merged already in #333 Do a |
Contributor
Author
|
this'll be for version 2.x though, not version 3.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…dler.
What does this change?
Checks to see if the off-canvas region is expanded before firing the close handler.
How to test
Right now, on a microsite, a click anywhere will fire the close handler, and focus jumps to the burger menu.
With this change, the close handler only fires if offCanvas is expanded, i.e. the mobile menu is active.
How can we measure success?
No unexpected jump to the top of the screen.
Images
No visual change.
Accessibility
Unaffected.