Make gaus_2d faster#273
Open
AlexKurek wants to merge 3 commits intolofar-astron:masterfrom
Open
Conversation
gmloose
reviewed
Apr 29, 2026
gmloose
reviewed
Apr 30, 2026
Comment on lines
+222
to
+223
| inv_sigx2 = 0.5 / (c[3]**2) | ||
| inv_sigy2 = 0.5 / (c[4]**2) |
Collaborator
There was a problem hiding this comment.
Just one minor nit-pick. Since you're going to need the negative value of these to calculate the exponent, would it not make sense to use -0.5 here already. It makes line 233 feel a bit more logic: ... N.exp(exponent), instead of ... N.exp(-exponent).
Author
There was a problem hiding this comment.
Good idea, changed. Benchamarking and .gaul file still are looking good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a 127 MB, 5762*5762 image,
atrous_do = True. Python 3.13, Numpy 2.4.tottimeandcumtimeare noticeably shorter.NGC6048_9-MFS-image.pybdsf.gaulfiles are identical.