Skip to content

Conversation

@bubriks
Copy link
Contributor

@bubriks bubriks commented Aug 7, 2025

This PR adds/fixes/changes...

  • please summarize your changes to the code
  • and make sure to include all changes to user-facing APIs

JIRA Issue: -

Priority for Review: -

Related PRs: -

How Has This Been Tested?

  • Unit Tests
  • Integration Tests
  • Manual Tests on VM

Checklist For The Assigned Reviewer:

- [ ] Checked if merge conflicts with master exist
- [ ] Checked if stylechecks for Java and Python pass
- [ ] Checked if all docstrings were added and/or updated appropriately
- [ ] Ran spellcheck on docstring
- [ ] Checked if guides & concepts need to be updated
- [ ] Checked if naming conventions for parameters and variables were followed
- [ ] Checked if private methods are properly declared and used
- [ ] Checked if hard-to-understand areas of code are commented
- [ ] Checked if tests are effective
- [ ] Built and deployed changes on dev VM and tested manually
- [x] (Checked if all type annotations were added and/or updated appropriately)

Copy link
Contributor

@kennethmhc kennethmhc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, few questions

+ ". Alternatively use Spark kernel."
if (feature_group.data_source.database and feature_group.data_source.group and feature_group.data_source.table) or feature_group.data_source.query:
# If the user provided a data source, we can use it to infer the schema
feature_group._features = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you infer from feature_group.data_source.query as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes query works.
here is an example:

def create_external_feature_group():
    data_source = fs.get_data_source("rds")

    # using table
    #data_source = data_source.get_tables("postgres")[0]

    # using query
    data_source.query = "SELECT * FROM postgres.public.users"

    fs.create_external_feature_group(
        name="users_test_query",
        version=2,
        primary_key=["id"],
        data_source=data_source
    ).save()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants