-
Notifications
You must be signed in to change notification settings - Fork 26
[FSTORE-1795] Update api to use data source and deprecate direct storage connector usage #621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
kennethmhc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, few questions
| + ". Alternatively use Spark kernel." | ||
| if (feature_group.data_source.database and feature_group.data_source.group and feature_group.data_source.table) or feature_group.data_source.query: | ||
| # If the user provided a data source, we can use it to infer the schema | ||
| feature_group._features = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you infer from feature_group.data_source.query as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes query works.
here is an example:
def create_external_feature_group():
data_source = fs.get_data_source("rds")
# using table
#data_source = data_source.get_tables("postgres")[0]
# using query
data_source.query = "SELECT * FROM postgres.public.users"
fs.create_external_feature_group(
name="users_test_query",
version=2,
primary_key=["id"],
data_source=data_source
).save()
This PR adds/fixes/changes...
JIRA Issue: -
Priority for Review: -
Related PRs: -
How Has This Been Tested?
Checklist For The Assigned Reviewer: