feat(amm-ui): add liquidity pool management flow#66
Merged
Conversation
a62a47c to
1c8db80
Compare
0x-r4bbit
approved these changes
Apr 28, 2026
Collaborator
0x-r4bbit
left a comment
There was a problem hiding this comment.
Rebased this one to work with the trade UI as well.
This was referenced Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds complete AMM liquidity UI covering all five issues: pool position summary, add-liquidity preview, remove-liquidity preview, slippage/min-received controls, and mock confirmation flow.
Changes
amm-ui/Main.qmlwithamm-ui/qml/Main.qml.amm-ui/metadata.jsonto loadqml/Main.qml.amm-ui/qml/pages/LiquidityPage.qmlas main page owner.amm-ui/qml/components/.amm-ui/qml/state/DummyPoolState.qmlfor local preview state.Structure choices
qml/becomes clear QML import/package root. Common QML layout; also simpler for Nix packaging because metadata points to one stable entry.Main.qmlstays thin. Page state and layout move toLiquidityPage.qml, so app shell does not become feature code.Commit details
e5c93c2-feat(amm/ui): add pool position summary (#60)Fixes #60.
Adds pool position summary UI with token pair, fee tier, user LP balance, pool share, owned token estimates, pool reserves, and LP supply. Establishes page structure and reusable summary rows used by later commits.
88e3f40-feat(amm/ui): add liquidity deposit preview (#61)Fixes #61.
Adds add-liquidity form with token amount inputs, balances, MAX action, pool-ratio helper, estimated LP tokens, and input validation. Preview updates before submit so user can inspect deposit effect.
e92a94d-feat(amm/ui): add remove-liquidity preview (#62)Fixes #62.
Adds remove-liquidity form with LP burn input, 25/50/75/MAX presets, share slider, expected token withdrawal, and post-withdrawal position preview. Uses same local pool state model for consistent add/remove math.
a65621c-feat(amm/ui): add slippage min received controls (#63)Fixes #63.
Adds slippage presets, custom tolerance input, min-received rows, clamping, and warning states. Shared slippage component keeps add/remove behavior consistent and avoids duplicated tolerance logic.
a62a47c-feat(amm/ui): add mock confirmation flow (#64)Fixes #64.
Adds submit-state handling, confirmation modal, cancel-preserves-input behavior, confirm-updates-dummy-state behavior, and success toast. Modal snapshots current form values so review screen matches action being confirmed.
Validation
nix build ./amm-ui#default --no-link --print-out-pathsqmllint qml/Main.qml qml/pages/*.qml qml/components/*.qml qml/state/*.qmlIssues
Fixes #60
Fixes #61
Fixes #62
Fixes #63
Fixes #64