Conversation
Provides the necessary instructions to run the AMM app inside Logos Basecamp. Closes #29
3esmit
left a comment
3esmit
left a comment
There was a problem hiding this comment.
- This PR closes #29, but it only adds manual AMM UI installation instructions and a flake description change; it does not add the AMM module as a Basecamp flake input, wire it into Basecamp's bundled/discoverable startup modules, or add the requested smoke test proving the module can open and close cleanly.
- The new README flow also mixes development and portable package paths: it documents
result-lgx-portableand the portable Basecamp data directory, but the install commands still useresult-lgxand the dev data directory, so users can install the wrong package into a directory Basecamp will not read.
Implement the actual Basecamp integration/test path and split the dev/portable install instructions. Also fix the public flake metadata typo from privacy preversed trading to the intended wording.
| This builds and runs the application in development mode. | ||
| This builds and runs the application in development mode. The Logos bridge is unavailable in standalone mode, but the UI layout and mock data are fully functional. | ||
|
|
||
| ## Running inside Logos Basecamp |
There was a problem hiding this comment.
This documents a manual local installation path, but it does not implement the Basecamp integration requested by #29. The linked issue asks for the AMM module to be added to Basecamp's flake inputs, bundled/discoverable at startup, and covered by a smoke test. As written, a fresh Basecamp build still has no AMM module wired into its preinstalled modules, so closing #29 from this PR would make the issue appear solved without changing the Basecamp runtime path.
| # BASECAMP_DIR="$HOME/.local/share/Logos/LogosBasecampDev" | ||
|
|
||
| # Install the UI plugin | ||
| lgpm --ui-plugins-dir "$BASECAMP_DIR/plugins" \ |
There was a problem hiding this comment.
This command always installs result-lgx/*.lgx into the dev data directory. That is correct only for the development package. If the user followed the portable build command above, this should instead install from result-lgx-portable/*.lgx and target the portable Basecamp data directory. Please split the dev and portable flows so the package variant, Basecamp variant, and data directory match.
| 1. Launch Basecamp | ||
| 2. Open Package Manager | ||
| 3. Select "Install from file" | ||
| 4. Choose the `.lgx` file from `result-lgx/` |
There was a problem hiding this comment.
This UI-install fallback also points only at result-lgx/, even though the section documents a portable build at result-lgx-portable/. Please either mention both outputs explicitly or keep the README to a single supported variant.
| @@ -1,5 +1,5 @@ | |||
| { | |||
| description = "Logos QML UI Module — replace with your description"; | |||
| description = "Logos Swap — Decentralized, privacy preversed trading"; | |||
There was a problem hiding this comment.
Small typo in public metadata: privacy preversed trading should be privacy-preserving trading .
3 participants
Provides the necessary instructions to run the AMM app inside Logos Basecamp.
Closes #29