Skip to content

fix(local): wait for stopped child processes#54

Open
andrussal wants to merge 1 commit intodevfrom
fix/robust-node-stop
Open

fix(local): wait for stopped child processes#54
andrussal wants to merge 1 commit intodevfrom
fix/robust-node-stop

Conversation

@andrussal
Copy link
Copy Markdown
Collaborator

This PR makes local test node cleanup wait for child processes to actually exit after sending the kill signal.

Previously local nodes were only asked to stop, but the framework did not wait for the process to be reaped before clearing node state. That can leave short-lived stale processes around and keep ports/resources busy after tests finish or fail.

@andrussal andrussal requested a review from hansieodendaal May 2, 2026 06:04
Copy link
Copy Markdown
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nit: We may want to spin up some concurrent futures for this:

for node in &mut state.nodes {
    node.stop_blocking();
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants