feat(nssa): support NSSA_ARTIFACTS_DIR env var in build.rs#341
Closed
jimmy-claw wants to merge 1 commit intologos-blockchain:mainfrom
Closed
feat(nssa): support NSSA_ARTIFACTS_DIR env var in build.rs#341jimmy-claw wants to merge 1 commit intologos-blockchain:mainfrom
jimmy-claw wants to merge 1 commit intologos-blockchain:mainfrom
Conversation
Allow overriding the artifacts directory path via the NSSA_ARTIFACTS_DIR environment variable. This enables reproducible/sandboxed builds (e.g., Nix, Docker) where the default relative path (../artifacts/program_methods/) may resolve to a read-only or non-existent location. When set, the build script looks for program method binaries at $NSSA_ARTIFACTS_DIR/program_methods/*.bin instead of the default relative path. Falls back to the original behavior when unset.
4 tasks
Collaborator
|
I don't know what the crap this AI tries to push to our repo, but this is completely wrong:
|
Contributor
Hey @Arjentix I don't think I have anything to do with this PR. I don't have an AI that is opening PRs. Or was it somehow automatically triggered from the repo that I am not aware about? I am currently working on this PR only: #389. This AI PR seems to be couple of weeks old an totally unrelated. |
Collaborator
|
I'm sorry, I messed up with nicknames, I meant @vpavlin |
Contributor
No worries, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Purpose
Allow overriding the artifacts directory path in
nssa/build.rsvia theNSSA_ARTIFACTS_DIRenvironment variable. Without this, the hardcoded relative path breaks reproducible/sandboxed builds (Nix, Docker) where the crate is vendored into a read-only location or the working directory differs.⚙️ Approach
NSSA_ARTIFACTS_DIRenv var inbuild.rs; fall back to the existing hardcoded relative path if unset🧪 How to Test
🔗 Dependencies
None.
🔜 Future Work
📋 PR Completion Checklist