feat(sequencer): add simulate_transaction RPC endpoint#443
Open
paschal533 wants to merge 13 commits intologos-blockchain:mainfrom
Open
feat(sequencer): add simulate_transaction RPC endpoint#443paschal533 wants to merge 13 commits intologos-blockchain:mainfrom
paschal533 wants to merge 13 commits intologos-blockchain:mainfrom
Conversation
…ationError Replace panicking .expect() calls in send_transaction with proper error propagation using TransactionMalformationError variants. Unify the size error to use TransactionMalformationError::TransactionTooLarge instead of a raw format string. Add unit tests for too-large and valid transaction paths.
Registers the new rejected-transaction column family in RocksDB, and exposes rejected_tx_column, put_rejected_tx, and get_rejected_tx on RocksDBIO for storing and retrieving RejectedTxRecord by hash.
…tx to SequencerStore
…roduction failure
…ulate block timestamp Restructure get_transaction_receipt to scope the sequencer lock to a block expression, collect a terminal receipt (Rejected/Included) under the lock, release the lock, then lazily remove the hash from pending_txs before returning. This fixes two related issues: - pending_txs grew without bound because insert() in send_transaction had no corresponding remove() when TXs were confirmed or rejected - a TX that had been included could still appear as Pending if the caller never queried its receipt Also populate timestamp_ms for Included receipts by fetching the block from the store (an additional DB read already cached by RocksDB's block cache), replacing the previous None placeholder. Lock ordering is preserved: sequencer lock is always released before pending_txs is acquired, matching the order in send_transaction.
…ard state pattern
paschal533
force-pushed
the
feat/simulate-transaction
branch
from
6eede91 to
222cbae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
simulate_transactionRPC method that executes a transaction against a snapshot of the current state and returns a structured result without ever committing the changes.Callers can use this to:
Design
The implementation follows a clone-and-discard pattern:
V03Stateis cloned, the lock is released immediately.validate_on_stateruns on the clone, never on the real state, so block production continues concurrently without contention.The simulation result includes:
successerrorsuccess == falseaccounts_modifiedVec<(AccountId, Account)>post-state for each touched accountnullifiers_createdcommitments_createdChanges
common/src/simulation.rs(new),SimulationResulttype.common/src/lib.rs, exposepub mod simulation.nssa/src/validated_state_diff.rs, exposenew_nullifiers()andnew_commitments()accessors onValidatedStateDiff(previously onlypublic_diff()was public).sequencer/service/src/service.rs,simulate_transactionimplementation with lock-release-before-execute pattern.sequencer/service/rpc/src/lib.rsandsequencer/service/protocol/src/lib.rs, RPC trait method and protocol type exports.Stacking note
This PR builds on top of #442 (receipt system) and #441 (crash fix). The
meaningful change in this PR starts at the
feat(common): add SimulationResultcommit.
Test plan
cargo test -p sequencer_service simulate, two tests:simulate_valid_transaction_returns_successandsimulate_does_not_modify_stateaccounts_modifiedshows the expected balance delta and the real account state is unchanged after the callsuccess == falseanderrorcontains a readable messagesimulate_transactioncalls while block production is active; confirm no lock contention and no state corruption