WIP: Implement deposit and withdraw cooldown period#92
Draft
WIP: Implement deposit and withdraw cooldown period#92
Conversation
0x-r4bbit
force-pushed
the
feat/deposit-cooldown-period
branch
from
8305c5e to
2b33c99
Compare
Collaborator
Author
|
Rebased on top of latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a work-in-progress which aims to introduce the deposit cooldown period and withdraw cooldown period.
During the implementation and testing of this feature, I ran into a bug which I've described in #91
Therefore, I think #14 is somewhat blocked now (unless we write tests in a way that they won't cause the bug described in #91 , but that would be only an artificial success).
I'm gonna leave this pending here until we've solved #48
Checklist
Ensure you completed all of the steps below before submitting your pull request:
forge snapshot?pnpm gas-report?pnpm lint?forge test?pnpm verify?