Add test coverage for parameter_extraction_cache_capacity type handling #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses logpai#109 by adding comprehensive test cases for the fix implemented in commit c7496f6. Tests ensure: - Integer values are handled correctly - String-to-int conversion works as expected - Edge cases are covered - Prevents regression of the original TypeError bug This provides quality assurance for configuration parameter handling and prevents the issue from reoccurring.
Addresses logpai#105 by adding comprehensive test cases for the fix implemented in commit c7496f6. Tests ensure: - Integer values are handled correctly - String-to-int conversion works as expected - Edge cases are covered - Prevents regression of the original TypeError bug This provides quality assurance for configuration parameter handling and prevents the issue from reoccurring.
…Drain3 into fix-issue-105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #105
This PR adds comprehensive test coverage for the
parameter_extraction_cache_capacityconfiguration parameter, addressing the bug that was fixed in commit c7496f6.Background
Issue #105 reported that users encountered a
TypeError: '>' not supported between instances of 'int' and 'str'when settingparameter_extraction_cache_capacity. While this was fixed in April 2024, there were no tests to prevent this bug from reoccurring.Changes
This PR adds the following test cases:
int>comparison)Testing
All tests pass locally:
Existing test suite continues to pass:
Motivation
As someone who has used Drain3 extensively for processing log data in my anomaly detection projects, I understand the importance of reliable configuration handling. This test coverage ensures that the fix remains stable and prevents regression, improving the developer experience for future users.
Related Issues