Docs: clarify that ssl_certificate_authorities takes at-most-one value#150
Merged
Docs: clarify that ssl_certificate_authorities takes at-most-one value#150
ssl_certificate_authorities takes at-most-one value#150Conversation
mashhurs
approved these changes
Jan 15, 2025
mashhurs
left a comment
mashhurs
left a comment
There was a problem hiding this comment.
LGTM!
The underlining limitation as we know, is Manticore client supports a single ca_file
flexitrev
reviewed
Jan 15, 2025
| @@ -348,10 +348,13 @@ NOTE: This setting can be used only if <<plugins-{type}s-{plugin}-ssl_key>> is s | |||
| ===== `ssl_certificate_authorities` | |||
|
|
|||
| * Value type is a list of <<path,path>> | |||
There was a problem hiding this comment.
Should we remove "a list of" to make it clearer?
Contributor
Author
There was a problem hiding this comment.
The value-type for the ssl_certificate_authorities setting across all plugins is a list, but the maximum capacity of that list in this particular plugin is one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ssl_certificate_authoritiestakes a list of files for purposes of the SSL/TLS Settings Standardization effort, but does not accept more than one entry in the list:LogStash::ConfigurationError: Multiple values on 'ssl_certificate_authorities are not supported by this pluginClarify this in docs.